-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUNIC: Add note about bushes to logic section of game info page #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
is: documentation
Improvements or additions to documentation.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
Jun 17, 2024
Exempt-Medic
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could maybe change:
There is also an option within the randomizer settings -> general settings to clear some early bushes.
into something like this, but it's fine as is:
There is also an option at "randomizer settings -> general settings" to clear some early bushes.
Co-authored-by: Silent <[email protected]>
ScipioWright
added
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
and removed
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
Jun 17, 2024
silent-destroyer
approved these changes
Jun 17, 2024
Exempt-Medic
approved these changes
Jun 17, 2024
NewSoupVi
approved these changes
Jun 18, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…ipelagoMW#3555) * Add note about bushes to logic section of readme * Update worlds/tunic/docs/en_TUNIC.md Co-authored-by: Silent <[email protected]> --------- Co-authored-by: Silent <[email protected]>
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…ipelagoMW#3555) * Add note about bushes to logic section of readme * Update worlds/tunic/docs/en_TUNIC.md Co-authored-by: Silent <[email protected]> --------- Co-authored-by: Silent <[email protected]>
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
…ipelagoMW#3555) * Add note about bushes to logic section of readme * Update worlds/tunic/docs/en_TUNIC.md Co-authored-by: Silent <[email protected]> --------- Co-authored-by: Silent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
is: documentation
Improvements or additions to documentation.
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Bush logic is weird, since there's many different ways past them. Some require progression items, some require items that are not currently marked progression, some require no items but require effort. Ultimately, the decision made was that they are not considered in logic, since they would force a sword or wand to show up basically immediately, especially in single player.
So, this just adds a note regarding it to the game info page that we can point at.
How was this tested?
Reading
If this makes graphical changes, please attach screenshots.
N/A