LADX: Converted to new options API (+other small refactors) #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
hatkirby
added
the
is: refactor/cleanup
NewSoupVi
requested changes
Jun 16, 2024
| patches.aesthetics.removeLowHPBeep(rom) | ||
| if 0 <= int(settings.linkspalette): | ||
| patches.aesthetics.forceLinksPalette(rom, int(settings.linkspalette)) | ||
| if 0 <= int(world.ladxr_settings.linkspalette): |
There was a problem hiding this comment.
I believe this is another unneeded cast
Suggested change
| if 0 <= int(world.ladxr_settings.linkspalette): | |
| if 0 <= world.ladxr_settings.linkspalette: |
There was a problem hiding this comment.
This one is a string, so the cast actually is needed.
Exempt-Medic
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Aside from two really minor things, these changes all LGTM. Asked a few questions about some of them and got clarifications, merged into main, did 500 random generations and saw that no warnings were printed for deprecated options, per_slot_randoms or anything else. Couldn't find any other obscure/hidden uses of deprecated option getters either. The playthroughs for the generated worlds looked fine as well
Co-authored-by: Exempt-Medic <[email protected]>
NewSoupVi
approved these changes
Jun 18, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…agoMW#3542) * Refactored various things * Renamed hidden variable in dungeon item shuffle block * Fixed LADXRSettings initialization * Rename ladxr_options -> ladxr_settings * Remove unnecessary int cast * Update worlds/ladx/LADXR/generator.py Co-authored-by: Exempt-Medic <[email protected]> --------- Co-authored-by: Exempt-Medic <[email protected]>
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…agoMW#3542) * Refactored various things * Renamed hidden variable in dungeon item shuffle block * Fixed LADXRSettings initialization * Rename ladxr_options -> ladxr_settings * Remove unnecessary int cast * Update worlds/ladx/LADXR/generator.py Co-authored-by: Exempt-Medic <[email protected]> --------- Co-authored-by: Exempt-Medic <[email protected]>
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
…agoMW#3542) * Refactored various things * Renamed hidden variable in dungeon item shuffle block * Fixed LADXRSettings initialization * Rename ladxr_options -> ladxr_settings * Remove unnecessary int cast * Update worlds/ladx/LADXR/generator.py Co-authored-by: Exempt-Medic <[email protected]> --------- Co-authored-by: Exempt-Medic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This PR contains a handful of refactors for LADX:
self.multiworld.randomorper_slot_randomsin favor of the world random field.self.multiworld, such as the player's name.How was this tested?
Ran 100 generations with random options. pytest continues to pass.
If this makes graphical changes, please attach screenshots.