Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon Red/Blue: Add new options to slot_data #3538

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Pokemon Red/Blue: Add new options to slot_data #3538

merged 2 commits into from
Jun 15, 2024

Conversation

coveleski
Copy link
Contributor

What is this fixing or adding?

Added require_pokedex, blind_trainers, and area_1_to_1 mapping, which would be helpful to the poptracker pack to more accurately reflect the checks available to players.

How was this tested?

Generated a game with 10 games, and checked the spoiler log against the info in slot_data

If this makes graphical changes, please attach screenshots.

No visual changes

Added require_pokedex, blind_trainers, and area_1_to_1 mapping, which would be helpful to the poptracker packs to accurately reflect the checks available to players.
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 15, 2024
@remyjette remyjette assigned remyjette and unassigned remyjette Jun 15, 2024
@remyjette
Copy link
Collaborator

oops
tried to assign @Alchav but misclicked
anyway there's your ping :)

@remyjette remyjette added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jun 15, 2024
@PoryGone PoryGone added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Jun 15, 2024
@NewSoupVi
Copy link
Member

NewSoupVi commented Jun 15, 2024

Happy to merge this quickly before 0.5.0 release, if Alchav approves it. It's a tiny, nondestructive change that will massively improve user experience

@remyjette remyjette added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 15, 2024
@NewSoupVi NewSoupVi merged commit 92023a2 into ArchipelagoMW:main Jun 15, 2024
17 checks passed
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
Added require_pokedex, blind_trainers, and area_1_to_1 mapping, which would be helpful to the poptracker packs to accurately reflect the checks available to players.
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Added require_pokedex, blind_trainers, and area_1_to_1 mapping, which would be helpful to the poptracker packs to accurately reflect the checks available to players.
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
Added require_pokedex, blind_trainers, and area_1_to_1 mapping, which would be helpful to the poptracker packs to accurately reflect the checks available to players.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants