WebHost: Fix Named Range displays on Player Options page #3521
Conversation
github-actions
bot
added
affects: webhost
NewSoupVi
added
is: bug/fix
NewSoupVi
added
the
waiting-on: peer-review
There was a problem hiding this comment.
Tho I do not disagree with the title part, I think the underscores in the special ranges are just a Stardew thing. Specifically with the Chefsanity option, since it was converted to a special range in 5.x.x, and the option names copied and pasted in the special ranges.
Also, this change should probably be applied as well to the weighted options
|
Oh, you're saying this is actually intentional on Stardew's part? I thought this was a bug If that's the case, I will just close this |
|
Confirmed that this is not a bug and Stardew just chose to have its names like this |
|
I asked Kaito beforehand about this, and it's worth noting that Stardew uses inconsistent cormatting then (see StartingMoney), all of which are displayed in a uniform fashion on the regular site. Regardless of anything specific to Stardew though, the new WebHost changes this for every game, Lufia 2 being a good example but also |
|
Reopening because my suggested world-side fix doesn't work If you have capital letters in |
github-actions
bot
added
the
affects: core
|
In fact, I just realised the docstring of the NamedRange class says that you can't use upper case letters So if that is going to be the case, we do at least need the call to Also yes, I should apply this to weighted options as well |
|
Ok, I think I got everything the way I want it now. |
…MW#3521) * Player Options: Fix Named Range displays * Also add validation to the NamedRange class itself * Don't break Stardew * Comment * Do replace first so title works correctly * Bring change to Weighted Options as well
…MW#3521) * Player Options: Fix Named Range displays * Also add validation to the NamedRange class itself * Don't break Stardew * Comment * Do replace first so title works correctly * Bring change to Weighted Options as well
…MW#3521) * Player Options: Fix Named Range displays * Also add validation to the NamedRange class itself * Don't break Stardew * Comment * Do replace first so title works correctly * Bring change to Weighted Options as well
…MW#3521) * Player Options: Fix Named Range displays * Also add validation to the NamedRange class itself * Don't break Stardew * Comment * Do replace first so title works correctly * Bring change to Weighted Options as well
As with my other two WebHost PRs, I have no idea if this is "structurally" the best fix.
Note: Just telling worlds to change the option names in
special_range_namesto what they want does not work. If any of the names in there contain capital letters, your yaml will never generate (unless you use the numeric values instead)Before:
After: