WebHost: Fix default values that are 2 or more words in Weighted Options #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
affects: webhost
NewSoupVi
added
is: bug/fix
github-actions
bot
added
the
waiting-on: peer-review
NewSoupVi
changed the title
NewSoupVi
added
the
affects: release/blocker
NewSoupVi
added
the
affects: webhost
Jouramie
reviewed
Jun 13, 2024
LegendaryLinux
approved these changes
Jun 13, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…ons (ArchipelagoMW#3519) * WeightedOptions: Fix default values that are 2 or more words * So much simpler
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…ons (ArchipelagoMW#3519) * WeightedOptions: Fix default values that are 2 or more words * So much simpler
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…ons (ArchipelagoMW#3519) * WeightedOptions: Fix default values that are 2 or more words * So much simpler
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
…ons (ArchipelagoMW#3519) * WeightedOptions: Fix default values that are 2 or more words * So much simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default option value for the Old Man option in Pokemon RB is "Early Parcel"
To check for the default in
weightedOptions/macros.html, we compare:option.get_option_name(option.default)|lower == nameProblem:
"Early Parcel"|lower != "early_parcelThe underscore is missing.
Alterate fixes that I considered:
|lower|replace(" ","_")Things that I could do ontop of this:
nametoreadable_nameand assignoption.get_option_name(id)to a new variable calledinternal_name. Bc either solution makes already long lines even longer.Lmk if either of those are better / desirable
Before:
After:
