sc2: update inno_setup.iss to remove old sc2wol world folder #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
MatthewMarinets
force-pushed
the
mm/fix_sc2_installer_on_update
branch
from
be851e2
to
1417be8
Compare
Exempt-Medic
added
the
is: maintenance
Berserker66
reviewed
Jun 9, 2024
Co-authored-by: Fabian Dill <[email protected]>
Ziktofel
approved these changes
Jun 9, 2024
Berserker66
approved these changes
Jun 10, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
When using the installer to update from old versions, the old sc2wol.apworld file isn't properly deleted, potentially resulting in issues when trying to start the sc2 client.
How was this tested?
It wasn't; I haven't worked with .iss files before and am running on Berserker's advice and copying how Rogue Legacy did things.
If this makes graphical changes, please attach screenshots.
None