Timespinner: add indirect connections #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
is: bug/fix
|
This seems to work, did a couple generations and checked the spoiler |
Jarno458
approved these changes
Jun 10, 2024
Jarno458
removed
the
waiting-on: world-maintainer
|
Personally not sure if this should be labeled as bugfix, seems more like an refactor to me, but i respect your decision |
|
I'm pretty sure this prevents a chance at failed generation because of the possibility of a 0-location sphere if the only checks unlocked are Ifrit (which would skip a sphere due to this issue). |
NewSoupVi
approved these changes
Jun 12, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Reviewing the spheres of an ongoing async showed that Timespinner is using
can_reach(Region)in an Entrance rule without defining indirect connections, so they would often "miss spheres".How was this tested?
Did some test generations, including with GyreArchives enabled. Ran unittests.
If this makes graphical changes, please attach screenshots.