Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: load frozen decompressed worlds #3488

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Core: load frozen decompressed worlds #3488

merged 1 commit into from
Jun 8, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

loads frozen decompiled worlds again, like non-apworld supported worlds

How was this tested?

With cx freeze 7.0.0 on python 3.11 on windows
Also needs #3224 for full fix.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 7, 2024
Copy link
Collaborator

@beauxq beauxq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reading code

LGTM

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Sorry for not catching that earlier.

@Berserker66 Berserker66 merged commit 0d9fce2 into main Jun 8, 2024
28 checks passed
@Berserker66 Berserker66 deleted the core_load_frozen branch June 8, 2024 18:03
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants