Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUNIC: Remove rule for west Quarry bomb wall #3481

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

ScipioWright
Copy link
Collaborator

What is this fixing or adding?

Neither of us really remember why we put this rule in the first place, and think the other person convinced them to do it. So we're removing it, since it's really unnecessary.

How was this tested?

It wasn't -- we are removing a rule, testing seems very unnecessary here.

If this makes graphical changes, please attach screenshots.

N/A

@ScipioWright ScipioWright added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 6, 2024
@ScipioWright ScipioWright changed the title TUNIC: Update rule for west Quarry bomb wall TUNIC: Remove rule for west Quarry bomb wall Jun 6, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's removing a rule, not much else to say

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 6, 2024
@NewSoupVi NewSoupVi merged commit 31419c8 into ArchipelagoMW:main Jun 6, 2024
17 checks passed
@ScipioWright ScipioWright deleted the patch-2 branch June 7, 2024 02:02
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
* Update west quarry bomb wall rule

* Update west quarry bomb wall rule
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
* Update west quarry bomb wall rule

* Update west quarry bomb wall rule
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
* Update west quarry bomb wall rule

* Update west quarry bomb wall rule
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
* Update west quarry bomb wall rule

* Update west quarry bomb wall rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants