Launcher: handle apworld installation #3472
Conversation
github-actions
bot
added
affects: core
|
It might be useful to detect if an apworld is frozen. The amount of frozen worlds released now is relatively low, but probably worth checking for. Absolutely not worth delaying for, but I think discussions on what metadata an apworld should contain should probably restart, if nothing for the use case of "is this apworld a newer version to the one currently installed, and if so, prompt the user if they want to update instead of throwing an exception". |
|
This will deny frozen apworlds as they have an |
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
| if worlds.user_folder is None: | ||
| raise Exception("Custom Worlds directory appears to not be writable.") | ||
| for world_source in worlds.world_sources: | ||
| if apworld_path.samefile(world_source.resolved_path): |
There was a problem hiding this comment.
One last thing - do you want to compare file content, or just make sure it doesn't try to have the same path in src and dst of copyfile? (because this doesn't compare content)
There was a problem hiding this comment.
The intention was preventing users from double clicking already installed apworlds and that mucking something up.
What is this fixing or adding?
Running Launcher with an APWorld will now install that APWorld. On Windows this can be triggered by double click an .apworld file.
How was this tested?
On Win10.
If this makes graphical changes, please attach screenshots.
Before:
After: