HK: adds split movement items to 'skills' item group #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
approved these changes
Jun 4, 2024
Exempt-Medic
added
the
waiting-on: world-maintainer
ScipioWright
approved these changes
Jun 4, 2024
ScipioWright
added
is: enhancement
BadMagic100
approved these changes
Jun 8, 2024
BadMagic100
added
waiting-on: core-review
NewSoupVi
approved these changes
Jun 8, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
added a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
because of extractedData labling, split movement items weren't in the 'skills' category, this adds all movement to skills appropriately
How was this tested?
added some prints before and after and imported the class in a shell, visually confirmed that the only things added to the group were the right/left/split movement items and that nothing was removed
If this makes graphical changes, please attach screenshots.