WebHost: allow getting checksum-specific datapackage via /api/datapackage/<checksum> #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
LegendaryLinux
approved these changes
Jun 8, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
…kage/<checksum> (ArchipelagoMW#3451) * WebHost: allow getting checksum-specific datapackage via /api/datapackage/<checksum> * match import style of /api/generate
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…kage/<checksum> (ArchipelagoMW#3451) * WebHost: allow getting checksum-specific datapackage via /api/datapackage/<checksum> * match import style of /api/generate
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…kage/<checksum> (ArchipelagoMW#3451) * WebHost: allow getting checksum-specific datapackage via /api/datapackage/<checksum> * match import style of /api/generate
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…kage/<checksum> (ArchipelagoMW#3451) * WebHost: allow getting checksum-specific datapackage via /api/datapackage/<checksum> * match import style of /api/generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds /api/datapackage/ which may be useful if we want to add /api/tracker stuff and return raw data, possibly has other uses.
How was this tested?
Locally, in which I realized not all checksums from currently loaded worlds can be accessed, as only datapackages that have been generated with, or hosted with, exist. Then I came to the follow up realization, that that doesn't matter, as the only time something would request that checksum is when it's hosted in some way on that website, which means it will be in the DB.
If this makes graphical changes, please attach screenshots.