Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebHost: weighted-options bugfixes #3448

Merged
merged 7 commits into from
Jun 3, 2024
Merged

WebHost: weighted-options bugfixes #3448

merged 7 commits into from
Jun 3, 2024

Conversation

LegendaryLinux
Copy link
Member

What is this fixing or adding?

Fixes several bugs in weighted-options

  • Fix word wrap breaking words outside acceptable breakpoints
  • Fix options not being populated with default values
  • Removes random-low, random-mid, and random-high variants from Toggle, Choice, and TextChoice options

How was this tested?

Locally, by running WebHost

If this makes graphical changes, please attach screenshots.

image
*Word-wrap fix and non-populated options fix not pictured

@LegendaryLinux LegendaryLinux added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: release/blocker Issues/PRs that must be addressed before next official release. affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 3, 2024
@LegendaryLinux LegendaryLinux self-assigned this Jun 3, 2024
@LegendaryLinux LegendaryLinux mentioned this pull request Jun 3, 2024
Closed
@Exempt-Medic Exempt-Medic mentioned this pull request Jun 3, 2024
Closed
@LegendaryLinux LegendaryLinux changed the title Weighted-Options bugfixes weighted-options bugfixes Jun 3, 2024
@ThePhar ThePhar changed the title weighted-options bugfixes WebHost: weighted-options bugfixes Jun 3, 2024
@Exempt-Medic
Copy link
Member

Generating from the advanced options page with these changes results in "Failed to generate options in test: Error generating option accessibility in The Witness - 'Could not find option "1" for "Accessibility", known options are locations, items, minimal'"

@ScipioWright ScipioWright added waiting-on: author Issue/PR is waiting for feedback or changes from its author. labels Jun 3, 2024
@Exempt-Medic
Copy link
Member

Generating from the advanced options page with these changes results in "Failed to generate options in test: Error generating option accessibility in The Witness - 'Could not find option "1" for "Accessibility", known options are locations, items, minimal'"

Fiddling around, it seems that changing lines 21 and 95 back to using name fixes this problem, but I don't know enough about this to know if that's a good idea

@LegendaryLinux LegendaryLinux merged commit 06e65c1 into main Jun 3, 2024
20 checks passed
@LegendaryLinux LegendaryLinux deleted the options-pages-fixes branch June 3, 2024 22:43
wu4 pushed a commit to wu4/Archipelago that referenced this pull request Jun 6, 2024
@LegendaryLinux @wu4
WebHost: weighted-options bugfixes (ArchipelagoMW#3448)
ca4c898 
* Fix improper css for word-break on player-options page

* Add default handling to weighted-options types

* Remove random-low/mid/high from Toggle, Choice, and TextChoice,

* Port key sorting for OptionList and OptionSet from player-options to weighted-options

* Ensure Choice and TextChoice values are set properly

* Remove debug line 🤦‍♂️
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
@LegendaryLinux @agilbert1412
WebHost: weighted-options bugfixes (ArchipelagoMW#3448)
51ff9a6 
* Fix improper css for word-break on player-options page

* Add default handling to weighted-options types

* Remove random-low/mid/high from Toggle, Choice, and TextChoice,

* Port key sorting for OptionList and OptionSet from player-options to weighted-options

* Ensure Choice and TextChoice values are set properly

* Remove debug line 🤦‍♂️
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@LegendaryLinux
WebHost: weighted-options bugfixes (ArchipelagoMW#3448)
d1a2f9b 
* Fix improper css for word-break on player-options page

* Add default handling to weighted-options types

* Remove random-low/mid/high from Toggle, Choice, and TextChoice,

* Port key sorting for OptionList and OptionSet from player-options to weighted-options

* Ensure Choice and TextChoice values are set properly

* Remove debug line 🤦‍♂️
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@LegendaryLinux @sflavelle
WebHost: weighted-options bugfixes (ArchipelagoMW#3448)
518c0c9 
* Fix improper css for word-break on player-options page

* Add default handling to weighted-options types

* Remove random-low/mid/high from Toggle, Choice, and TextChoice,

* Port key sorting for OptionList and OptionSet from player-options to weighted-options

* Ensure Choice and TextChoice values are set properly

* Remove debug line 🤦‍♂️
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@LegendaryLinux @qwint
WebHost: weighted-options bugfixes (ArchipelagoMW#3448)
90bbcfc 
* Fix improper css for word-break on player-options page

* Add default handling to weighted-options types

* Remove random-low/mid/high from Toggle, Choice, and TextChoice,

* Port key sorting for OptionList and OptionSet from player-options to weighted-options

* Ensure Choice and TextChoice values are set properly

* Remove debug line 🤦‍♂️
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
@LegendaryLinux @AustinSumigray
WebHost: weighted-options bugfixes (ArchipelagoMW#3448)
a3c9867 
* Fix improper css for word-break on player-options page

* Add default handling to weighted-options types

* Remove random-low/mid/high from Toggle, Choice, and TextChoice,

* Port key sorting for OptionList and OptionSet from player-options to weighted-options

* Ensure Choice and TextChoice values are set properly

* Remove debug line 🤦‍♂️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThePhar ThePhar ThePhar approved these changes

@alwaysintreble alwaysintreble Awaiting requested review from alwaysintreble

Assignees

@LegendaryLinux LegendaryLinux

Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LegendaryLinux @Exempt-Medic @ThePhar @ScipioWright