Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoR2: Add Support for New Stage #3436

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

kindasneaki
Copy link
Collaborator

What is this fixing or adding?

Adds support for the newly added stage in Risk of Rain 2. This stage will be available to both vanilla and the DLC.
Also this adds in option groups to better visualize the options for the two different modes that are select-able.

How was this tested?

Played a solo world and will be releasing the apworld, so other players will be able to test/play the new stage in AP.

If this makes graphical changes, please attach screenshots.

image

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 2, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jun 2, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged into main, got the new client, tested that the new stage worked (it could be gone to, left from, it worked as a received item and as a starting stage, and checks within it could be sent out)

Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option groups did not appear on Webhost because the changes aren't on this branch.

@kindasneaki
Copy link
Collaborator Author

Option groups did not appear on Webhost because the changes aren't on this branch.

Guess I forgot to hit push... Thanks for catching that.

Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nitpick, but looks good. Tested generation and Webhost changes but not client.

worlds/ror2/options.py Outdated Show resolved Hide resolved
worlds/ror2/options.py Outdated Show resolved Hide resolved
@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Jun 3, 2024
@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 4, 2024
@NewSoupVi NewSoupVi merged commit f30f2d3 into ArchipelagoMW:main Jun 4, 2024
16 checks passed
@kindasneaki kindasneaki deleted the ror2_new_stage branch June 4, 2024 19:46
wu4 pushed a commit to wu4/Archipelago that referenced this pull request Jun 6, 2024
* add support for the new stage added to RoR2

* Fix stage being unreachable

* add option groups

* reorder option groups
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
* add support for the new stage added to RoR2

* Fix stage being unreachable

* add option groups

* reorder option groups
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
* add support for the new stage added to RoR2

* Fix stage being unreachable

* add option groups

* reorder option groups
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
* add support for the new stage added to RoR2

* Fix stage being unreachable

* add option groups

* reorder option groups
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
* add support for the new stage added to RoR2

* Fix stage being unreachable

* add option groups

* reorder option groups
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
* add support for the new stage added to RoR2

* Fix stage being unreachable

* add option groups

* reorder option groups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants