Muse Dash: Remove regions for a decent speed gain in generating worlds #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeamonHunter
added
the
is: refactor/cleanup
github-actions
bot
added
the
waiting-on: peer-review
nicholassaylor
approved these changes
Jun 4, 2024
agilbert1412
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
I'm not sure I agree with the idea behind the PR, but it comes from the world maintainer so I defer to their design decisions. I'm actually surprised this improves performance, that goes against what I thought I knew about region performance.
The code seems good, it does what it claims to do
Exempt-Medic
approved these changes
Jun 10, 2024
Exempt-Medic
added
waiting-on: core-review
NewSoupVi
approved these changes
Jun 11, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
ArchipelagoMW#3435) * Remove Muse Dash Regions. * Update comments.
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
ArchipelagoMW#3435) * Remove Muse Dash Regions. * Update comments.
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
ArchipelagoMW#3435) * Remove Muse Dash Regions. * Update comments.
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
ArchipelagoMW#3435) * Remove Muse Dash Regions. * Update comments.
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
ArchipelagoMW#3435) * Remove Muse Dash Regions. * Update comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Removes the regions for Muse Dash in order to gain a decent amount of performance for larger worlds.
How was this tested?
Tests and checking the generation log to ensure nothing broke.
Performance testing
Tests were not done with set seeds. As the performance difference was consistently large.