Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stardew valley: Create Option Groups #3376

Merged
merged 9 commits into from
May 23, 2024
Merged

Stardew valley: Create Option Groups #3376

merged 9 commits into from
May 23, 2024

Conversation

agilbert1412
Copy link
Collaborator

What is this fixing or adding?

Created Option groups for Stardew Valley, to improve the user experience

How was this tested?

Ran the webhost locally and looked at it. It's alright

If this makes graphical changes, please attach screenshots.

image

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 22, 2024
@agilbert1412 agilbert1412 added the is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. label May 22, 2024
benny-dreamly
benny-dreamly approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@benny-dreamly benny-dreamly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t look at the code much but the visuals look great

Ishigh1
Ishigh1 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Ishigh1 Ishigh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except Multiple Day Sleep being separated on two distinct columns, everything looks good

@agilbert1412 agilbert1412 added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. affects: webhost Issues/PRs that touch webhost and may need additional validation. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels May 22, 2024
Exempt-Medic
Exempt-Medic approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My questions about the groups were addressed, this all LGTM

@NewSoupVi NewSoupVi merged commit 89d0dae into ArchipelagoMW:main May 23, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@agilbert1412
Stardew valley: Create Option Groups (ArchipelagoMW#3376)
b50e20d 
* - Fix link in Stardew Setup Guide

* - Create option groups for Stardew Valley

* - Cleaned up the imports

* - Fixed double quotes and trailing comma

* - Improve order in the multipliers category
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@agilbert1412 @sflavelle
Stardew valley: Create Option Groups (ArchipelagoMW#3376)
778fd51 
* - Fix link in Stardew Setup Guide

* - Create option groups for Stardew Valley

* - Cleaned up the imports

* - Fixed double quotes and trailing comma

* - Improve order in the multipliers category
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@agilbert1412 @qwint
Stardew valley: Create Option Groups (ArchipelagoMW#3376)
e1fe999 
* - Fix link in Stardew Setup Guide

* - Create option groups for Stardew Valley

* - Cleaned up the imports

* - Fixed double quotes and trailing comma

* - Improve order in the multipliers category
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benny-dreamly benny-dreamly benny-dreamly approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@Ishigh1 Ishigh1 Ishigh1 approved these changes

Assignees
No one assigned
Labels
is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agilbert1412 @Ishigh1 @NewSoupVi @Exempt-Medic @benny-dreamly