Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebHost: Fixing default values for LocationSets #3374

Merged
merged 2 commits into from
May 22, 2024
Merged

WebHost: Fixing default values for LocationSets #3374

merged 2 commits into from
May 22, 2024

Conversation

Exempt-Medic
Copy link
Member

What is this fixing or adding?

Issue 3373

LocationSets with default values were not working.

How was this tested?

Generations, looking at WebHost, and exporting yamls.

@github-actions github-actions bot added affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 22, 2024
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label May 22, 2024
hatkirby
hatkirby approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@hatkirby hatkirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Spelling is hard.

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 22, 2024
ScipioWright
ScipioWright approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grop

@NewSoupVi NewSoupVi merged commit 1ae0a9b into ArchipelagoMW:main May 22, 2024
10 checks passed
@Exempt-Medic Exempt-Medic mentioned this pull request May 22, 2024
Closed
@Exempt-Medic Exempt-Medic deleted the patch-12 branch June 1, 2024 13:48
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@Exempt-Medic
WebHost: Fixing default values for LocationSets (ArchipelagoMW#3374)
55cde21 
* Update macros.html

* Update macros.html
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@Exempt-Medic @sflavelle
WebHost: Fixing default values for LocationSets (ArchipelagoMW#3374)
e5573bd 
* Update macros.html

* Update macros.html
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Exempt-Medic @qwint
WebHost: Fixing default values for LocationSets (ArchipelagoMW#3374)
c15787e 
* Update macros.html

* Update macros.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

@hatkirby hatkirby hatkirby approved these changes

Assignees
No one assigned
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Exempt-Medic @hatkirby @ScipioWright @NewSoupVi