CV64: Add option groups #3360
Merged
CV64: Add option groups #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
|
A couple of these option descriptions would probably be better as single longer lines to avoid having awkward line breaks in the middle of sentences whose exact display varies by browser settings. |
LegendaryLinux
approved these changes
May 21, 2024
|
Got rid of all mid-sentence line breaks and I think I'm pretty happy with it now. I also decided to decrease the default value for |
Exempt-Medic
added
waiting-on: core-review
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
* Add the option groups. * Get rid of all mid-sentence line breaks.
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
* Add the option groups. * Get rid of all mid-sentence line breaks.
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* Add the option groups. * Get rid of all mid-sentence line breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds option groups for CV64 and changes the formatting of the option descriptions to remove indentations whenever there's a manual line break.
How was this tested?
Ran the WebHost and made sure it all looked good there.
If this makes graphical changes, please attach screenshots.