Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use world.web.options_presets directly #3348

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

LegendaryLinux
Copy link
Member

What is this fixing or adding?

This prevents a crash on Python 3.8 by removing a bitwise or comparison between two dicts

How was this tested?

Tested locally by running WebHost

@github-actions github-actions bot added the affects: webhost Issues/PRs that touch webhost and may need additional validation. label May 20, 2024
@LegendaryLinux LegendaryLinux added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: refactor/cleanup Improvements to code/output readability or organizization. affects: PR/blocker Issue/PR blocks another PR. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. labels May 20, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 20, 2024
@ThePhar
Copy link
Member

ThePhar commented May 20, 2024

Confirmed WebHost started on 3.8 with this PR.

@LegendaryLinux LegendaryLinux merged commit bfe215d into main May 20, 2024
26 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: PR/blocker Issue/PR blocks another PR. affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants