Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Witness: Option Groups & Tooltip formatting #3342

Merged
merged 6 commits into from
May 21, 2024
Merged

The Witness: Option Groups & Tooltip formatting #3342

merged 6 commits into from
May 21, 2024

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented May 19, 2024 •
edited
Loading

uwu notices your options

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 19, 2024
@NewSoupVi
Copy link
Member Author

What did I do lmao

@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label May 19, 2024
ScipioWright
ScipioWright approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine on webhost, no issues.

Exempt-Medic
Exempt-Medic approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM and display well when running WebHost

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 21, 2024
LegendaryLinux
LegendaryLinux approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@LegendaryLinux LegendaryLinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I'm checking out and verifying all these changes anyway, I would appreciate screenshots next time. The template does ask for them, and this did make graphical changes.

@LegendaryLinux LegendaryLinux merged commit 61be79b into ArchipelagoMW:main May 21, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@NewSoupVi
The Witness: Option Groups & Tooltip formatting (ArchipelagoMW#3342)
405f408 
* Add option groups

* Option tooltip formatting

* eof

* reindent, apparently I'm stupid

* lint

* oops indent
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@NewSoupVi @sflavelle
The Witness: Option Groups & Tooltip formatting (ArchipelagoMW#3342)
de0f8cc 
* Add option groups

* Option tooltip formatting

* eof

* reindent, apparently I'm stupid

* lint

* oops indent
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@NewSoupVi @qwint
The Witness: Option Groups & Tooltip formatting (ArchipelagoMW#3342)
ba8c479 
* Add option groups

* Option tooltip formatting

* eof

* reindent, apparently I'm stupid

* lint

* oops indent
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
@NewSoupVi @AustinSumigray
The Witness: Option Groups & Tooltip formatting (ArchipelagoMW#3342)
123505d 
* Add option groups

* Option tooltip formatting

* eof

* reindent, apparently I'm stupid

* lint

* oops indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

@LegendaryLinux LegendaryLinux LegendaryLinux approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NewSoupVi @LegendaryLinux @ScipioWright @Exempt-Medic