Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: re-introduce per-Room Locker #3337

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Hopefully nothing. But maybe a recent rollback occured due to multi-hosting the same room and an outdated shadow version writing to DB? Unknown if that was the reason, but this should remove the possibility.

How was this tested?

Ran it, nothing more.

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the affects: webhost Issues/PRs that touch webhost and may need additional validation. label May 19, 2024
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job rendering the diff, github.

Assuming this only adds 2 lines and a bunch of spaces, the worst that can happen is not spinning up rooms.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 19, 2024
@Berserker66
Copy link
Member Author

Yeah, it's just formatting, the other lines are otherwise unchanged.

@Berserker66 Berserker66 merged commit d3f4ee4 into main May 19, 2024
26 checks passed
@Berserker66 Berserker66 deleted the webhost_room_locker branch May 19, 2024 15:04
Berserker66 added a commit that referenced this pull request May 19, 2024
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants