CustomServer: don't mutate static server data #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when switching to multiple rooms per process, we ended up modifying the static server data because that's how _load works and the data is now shared between multiple rooms.
github-actions
bot
added
affects: webhost
Berserker66
approved these changes
May 19, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
when switching to multiple rooms per process, we ended up modifying the static server data because that's how _load works and the data is now shared between multiple rooms.
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
when switching to multiple rooms per process, we ended up modifying the static server data because that's how _load works and the data is now shared between multiple rooms.
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
when switching to multiple rooms per process, we ended up modifying the static server data because that's how _load works and the data is now shared between multiple rooms.
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
when switching to multiple rooms per process, we ended up modifying the static server data because that's how _load works and the data is now shared between multiple rooms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3327 but rebased for main