WebHost: fix AutoLauncher restarting rooms due to race condition #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
black-sliver
approved these changes
May 19, 2024
Co-authored-by: black-sliver <[email protected]>
There was a problem hiding this comment.
Another thing I just realized is that rooms_shutting_down.put(room_id) won't run if there is an exception during shutdown (re-raise or in finally). So the room(s) then gets stuck, Maybe move rooms_shutting_down to finally and wrap the db_session in the finally block in a try-except-log?
black-sliver
approved these changes
May 19, 2024
Berserker66
added a commit
that referenced
this pull request
May 19, 2024
(cherry picked from commit 663b50b)
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Rooms are spinning too much
How was this tested?
locally
If this makes graphical changes, please attach screenshots.