WebHost: fixup WebHostLib/options.py #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
Berserker66
commented
May 19, 2024
Berserker66
commented
May 19, 2024
LegendaryLinux
approved these changes
May 19, 2024
There was a problem hiding this comment.
So the answer to my question in the previous PR would have been:
"You should create a new function which accepts both options and meta options as separate arguments and returns the html for the wait page. This function should be called by both the POST handler in the API and by the options pages."
LegendaryLinux
requested changes
May 19, 2024
LegendaryLinux
approved these changes
May 19, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
* WebHost: fixup WebHostLib/options.py * Update WebHostLib/options.py * Update WebHostLib/options.py * fix visibility flag handling
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
* WebHost: fixup WebHostLib/options.py * Update WebHostLib/options.py * Update WebHostLib/options.py * fix visibility flag handling
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* WebHost: fixup WebHostLib/options.py * Update WebHostLib/options.py * Update WebHostLib/options.py * fix visibility flag handling
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
* WebHost: fixup WebHostLib/options.py * Update WebHostLib/options.py * Update WebHostLib/options.py * fix visibility flag handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
auto-fix imports
added typing
removed self-calling network request
removed forfeit-mode again, which had been gone for months
removed explicit settings and let them default instead
extracted "start_generation" as function in WebHostLib/generate.py
options pages no longer redirect to archipelago.gg
fix Visibility being used via <, instead of like an intflag
How was this tested?
using the generate buttons on the player options page of Factorio and the upload yaml page.
If this makes graphical changes, please attach screenshots.