Skip to content

Pokemon RB: Add an item group for each HM to improve hinting #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Pokemon RB: Add an item group for each HM to improve hinting #3311

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
823af8d
Pokemon RB: Add an item group for each HM
remyjette May 16, 2024
9818665
Add the new groups for HMs in the item_table instead
remyjette May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion worlds/pokemon_rb/items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,13 @@ def __init__(self, item_id, classification, groups):
)


item_groups = {}
item_groups = {
"HM01": {"HM01 Cut"},
"HM02": {"HM02 Fly"},
"HM03": {"HM03 Surf"},
"HM04": {"HM04 Strength"},
"HM05": {"HM05 Flash"},
}
for item, data in item_table.items():
for group in data.groups:
item_groups[group] = item_groups.get(group, []) + [item]
Loading