-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Fix auto-fill in the text client when clicking on a hint suggestion #3267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Tested it locally and it worked, even with some pathological-seeming item names like Watch '? ( Battery
because of get_text_between
using rindex
Now that you say it, there's an edge case that won't work if the player hints for something that contains |
Bonus Points for a Unittest that prevents this in the future. |
I think making a new module I think it would be better to put it in |
Well then, where in Utils? At the end? No one gave me clear indications except Black Silver who said to put it inside a util module |
after |
Well I moved it to where you suggested |
Right, I forgot to reformat the file for once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested without looking too hard for edge cases
looked over code
What is this fixing or adding?
#2833 added more details to failed hints commands, which broke the hint suggestion copy system that was expecting a different string, so I fixed it here
How was this tested?
By left clicking the different things that are auto-fillable when clicked on
If this makes graphical changes, please attach screenshots.
(previous behavior was the same but nothing in the textbox after a click)