Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Witness: Use OptionError #3258

Merged
merged 2 commits into from
May 17, 2024
Merged

The Witness: Use OptionError #3258

merged 2 commits into from
May 17, 2024

Conversation

NewSoupVi
Copy link
Member

Use the new OptionError class for the invalid settings combination Exception

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 3, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label May 3, 2024
Exempt-Medic
Exempt-Medic approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged into main, tested that the error was now an OptionError. There are no other Exceptions in the world, so nothing else needs to be updated

black-sliver
black-sliver approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise is raise, so this should be be able to have negative impact anywhere.

@black-sliver black-sliver merged commit 88dd27e into ArchipelagoMW:main May 17, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@NewSoupVi
The Witness: Use OptionError (ArchipelagoMW#3258)
a2a1f78 
* Use OptionError

* ruff
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@NewSoupVi @qwint
The Witness: Use OptionError (ArchipelagoMW#3258)
fffce23 
* Use OptionError

* ruff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NewSoupVi @black-sliver @Exempt-Medic