TLOZ: Fix rings classification, so they are actually considered for logic #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logic We have a whole set of rules set up (Lines 31-38 of Rules.py) to make it so players are not expected to go into dungeons without a certain level of defense, which is n-1 heart containers for each level. We also had it set up that blue ring would reduce the number of containers expected by half, and red ring by a quarter...but currently both rings are classified as useful, meaning they aren't actually considered for logic. I was informed about this a while ago and thought I had already submitted a fix for it, but apparently I forgor. I'm rectifying that now, changing the classification for both rings to progression and also adding a comment to the loop that sets up this defense rule in Rules.py as I kept losing track of where it was.
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: bug/fix
ScipioWright
approved these changes
May 2, 2024
ScipioWright
added
waiting-on: core-review
Exempt-Medic
approved these changes
May 2, 2024
ThePhar
changed the title
ThePhar
approved these changes
May 2, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
We have a whole set of rules set up (Lines 31-38 of Rules.py) to make it so players are not expected to go into dungeons without a certain level of defense, which is n-1 heart containers for each level. We also had it set up that blue ring would reduce the number of containers expected by half, and red ring by a quarter...but currently both rings are classified as useful, meaning they aren't actually considered for logic. I was informed about this a while ago and thought I had already submitted a fix for it, but apparently I forgor. I'm rectifying that now, changing the classification for both rings to progression and also adding a comment to the loop that sets up this defense rule in Rules.py as I kept losing track of where it was.
How was this tested?
Ran dozens of test gens and the unit tests, as well as checked spoilers and noted that rings showed up in playthroughs now.
If this makes graphical changes, please attach screenshots.