-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Make output when hinting something with multiple copies show up in a better order #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Issues/PRs that touch core and may need additional validation.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
May 2, 2024
ScipioWright
added
the
is: enhancement
Issues requesting new features or pull requests implementing new features.
label
May 2, 2024
NewSoupVi
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOATed change, code makes sense, worked in practice when I tried it
Exempt-Medic
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ordering displayed for all 27 states of having available hints.
ScipioWright
added
waiting-on: author
Issue/PR is waiting for feedback or changes from its author.
and removed
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
May 3, 2024
ScipioWright
added
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
and removed
waiting-on: author
Issue/PR is waiting for feedback or changes from its author.
labels
May 3, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
… in a better order (ArchipelagoMW#3245) * Make the hint info show up in a better order * Change how old_hints is modified/done --------- Co-authored-by: NewSoupVi <[email protected]>
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
… in a better order (ArchipelagoMW#3245) * Make the hint info show up in a better order * Change how old_hints is modified/done --------- Co-authored-by: NewSoupVi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects: core
Issues/PRs that touch core and may need additional validation.
is: enhancement
Issues requesting new features or pull requests implementing new features.
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Currently, when you hint an item that has multiple copies in the world, where some have been found, some have been previously hinted and found, some previously hinted and not found, etc., it outputs in this order:
This order isn't great, and gets worse the more copies of an item there are (hinting mcguffins for example).
This PR changes it so that it is in this order:
How was this tested?
Hosted a game with a few slots, released two of them, hinted from one of the released slots to verify the order was as desired. I recommend others test it too, because there's a good chance that there are scenarios that I missed.
Note for anyone who wants to test it: The server must be hosted locally, since this change is to the server, not the text client.
If this makes graphical changes, please attach screenshots.
Before:
After: