HK: Fix Godhome Events #3221
Merged
HK: Fix Godhome Events #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make them non-events when unshuffled is on
github-actions
bot
added
the
waiting-on: peer-review
BadMagic100
approved these changes
Apr 26, 2024
ScootyPuffJr1
added
the
is: bug/fix
ScipioWright
approved these changes
Apr 26, 2024
ScipioWright
added
waiting-on: core-review
NewSoupVi
approved these changes
May 2, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…make them non-events when unshuffled is on (ArchipelagoMW#3221)
qwint
added a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…make them non-events when unshuffled is on (ArchipelagoMW#3221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
move godhome events to create_regions with the others to not try and make them non-events when unshuffled is on
How was this tested?
generated with a mix of goals and unshuffled settings and released to confirm the correct amount of non-event items were created
If this makes graphical changes, please attach screenshots.