[MMBN3] Fixes incorrect "Game Completion" Flag getting set #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
is: bug/fix
Exempt-Medic
approved these changes
Apr 27, 2024
ScipioWright
approved these changes
May 6, 2024
ScipioWright
added
waiting-on: core-review
NewSoupVi
approved these changes
May 7, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds in a check preventing the game from reading garbage data as a game completion flag. Addressing a bug report in Discord
Idling on the title screen long enough could write garbage data to the Save ROM when the title screen restarts. This data can sometimes write to the area of the Save that the client uses to check if the game is completed.
How was this tested?
Ran the attached seed in the discord post with and without Lua fix for 30 minutes. Pre-patch consistently hit the bug within a few minutes, post-patch the bug never occurred.