Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTTP: 0.4.6 fixes #3215

Merged
merged 4 commits into from
Apr 27, 2024
Merged

ALTTP: 0.4.6 fixes #3215

merged 4 commits into from
Apr 27, 2024

Conversation

Alchav
Copy link
Contributor

@Alchav Alchav commented Apr 26, 2024 •
edited
Loading

What is this fixing or adding?

  • Initialize treasure_hunt_count treasure_hunt_required to 0 so that it does not write 1 into the rom when there is no Triforce Hunt, which creates Murahdahla and the Triforce Hunt HUD.
  • Adds bomb logic to the Randomizer Room
  • Corrects Moblin KDS fix rom address for Circle of Pots room key drop enemy.
  • Renames treasure_hunt_count to treasure_hunt_required and adds a treasure_hunt_total variable to the ALTTP world to track the total number of triforce pieces, which is now used for Murahdala's text.

How was this tested?

  • Generated with and without Triforce Hunt, observing Triforce Hunt HUD only when Triforce Hunt is on.
  • Unit tests for bomb logic.
  • Used Hyrule Magic to modify circle of pots enemy, compared roms, found correct rom address. The address pointed to now is the X position for that enemy. (hard to test because it could be many attempts before Enemizer places a Moblin)
  • Generated a Triforce Hunt with 17 required and 34 total pieces, using the Percentage mode, and confirmed Murahdala's text was correct.

@Alchav Alchav requested a review from Berserker66 as a code owner April 26, 2024 03:58
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 26, 2024
@Grrmo
Copy link
Contributor

Grrmo commented Apr 26, 2024

Murahdahla always says that there's exactly 30 Triforce pieces available now no matter how many there truly are. Can you adress this please within this PR?

@ScipioWright ScipioWright added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 26, 2024
@Alchav
Copy link
Contributor Author

Alchav commented Apr 27, 2024

Murahdahla always says that there's exactly 30 Triforce pieces available now no matter how many there truly are. Can you adress this please within this PR?

It is done!

AP 90269022204012742314 P1 AlchavZ3 2024-04-26 23 47 16

@Grrmo
Copy link
Contributor

Grrmo commented Apr 27, 2024 •
edited
Loading

you are the best! 🥰

@Berserker66 Berserker66 merged commit 9afe451 into ArchipelagoMW:main Apr 27, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@Alchav
ALTTP: 0.4.6 fixes (ArchipelagoMW#3215)
7787261 
* Fix randomizer room logic

* Fix Triforce Hunt HUD always present

* Fix Circle of Pots enemy byte

* treasure_hunt_total for Murahdala text
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Alchav @qwint
ALTTP: 0.4.6 fixes (ArchipelagoMW#3215)
612e756 
* Fix randomizer room logic

* Fix Triforce Hunt HUD always present

* Fix Circle of Pots enemy byte

* treasure_hunt_total for Murahdala text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alchav @Grrmo @Berserker66 @ScipioWright