-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALTTP: Updates and refactors to multi-tracker and player tracker. #3183
Merged
LegendaryLinux
merged 9 commits into
ArchipelagoMW:main
from
ThePhar:alttp_multitracker_updates
Apr 20, 2024
Merged
ALTTP: Updates and refactors to multi-tracker and player tracker. #3183
LegendaryLinux
merged 9 commits into
ArchipelagoMW:main
from
ThePhar:alttp_multitracker_updates
Apr 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds dropdowns separated by region for each location and its checked status. * Adds Bombs for bombless start seeds. * Adds Triforce Pieces to track. * Update icon image URLs to match in-game closer. * Fix issue with grouped progressive items.
# Conflicts: # WebHostLib/templates/tracker__ALinkToThePast.html # WebHostLib/tracker.py
ThePhar
added
is: bug/fix
Issues that are reporting bugs or pull requests that are fixing bugs.
is: refactor/cleanup
Improvements to code/output readability or organizization.
affects: webhost
Issues/PRs that touch webhost and may need additional validation.
labels
Apr 20, 2024
github-actions
bot
added
the
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
label
Apr 20, 2024
LegendaryLinux
approved these changes
Apr 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…chipelagoMW#3183) * ALTTP: Massive game tracker update. * Adds dropdowns separated by region for each location and its checked status. * Adds Bombs for bombless start seeds. * Adds Triforce Pieces to track. * Update icon image URLs to match in-game closer. * Fix issue with grouped progressive items. * Couple missed points. * Another edge case with details being refreshed. * Remove old commented out CSS * Consolidate a table and move an erroneous location in wrong region. * ALTTP: Updates and refactors to multi-tracker and player tracker. * Removed some missed commented out code. * Add triforce to prepare inventory logic.
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
…chipelagoMW#3183) * ALTTP: Massive game tracker update. * Adds dropdowns separated by region for each location and its checked status. * Adds Bombs for bombless start seeds. * Adds Triforce Pieces to track. * Update icon image URLs to match in-game closer. * Fix issue with grouped progressive items. * Couple missed points. * Another edge case with details being refreshed. * Remove old commented out CSS * Consolidate a table and move an erroneous location in wrong region. * ALTTP: Updates and refactors to multi-tracker and player tracker. * Removed some missed commented out code. * Add triforce to prepare inventory logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects: webhost
Issues/PRs that touch webhost and may need additional validation.
is: bug/fix
Issues that are reporting bugs or pull requests that are fixing bugs.
is: refactor/cleanup
Improvements to code/output readability or organizization.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
A few more refactors the the player-specific tracker, including removing hard coding of locations in tracker (obtains information from multidata directly).
As for multi-tracker, adds support for all the new locations, fixes key counts, adds bombs (for bombless start), and refactors some of the ordering.
How was this tested?
Sent items in progressive/non-progressive seeds and checked output. Everything seems to be in order.
If this makes graphical changes, please attach screenshots.