LttP/Core: more ripping and tearing #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
worlds/alttp/Rules.py
Outdated
|
|
||
| set_rule(world.get_location('Thieves\' Town - Attic', player), lambda state: state._lttp_has_key('Small Key (Thieves Town)', player, 3)) | ||
| set_rule(world.get_location('Thieves\' Town - Spike Switch Pot Key', player), | ||
| if multiworld.accessibility[player] != 'locations' and not world.key_drop_shuffle[player]: |
There was a problem hiding this comment.
Suggested change
| if multiworld.accessibility[player] != 'locations' and not world.key_drop_shuffle[player]: | |
| if multiworld.accessibility[player] != 'locations' and not multiworld.key_drop_shuffle[player]: |
Did not test this, but it seems to be the problem here.
Merged
Berserker66
pushed a commit
that referenced
this pull request
Apr 19, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
now that more LttP options are at least on the outdated options system, they can be removed from core.
sprite and sprite_pool still aren't, so those and EntranceRandomizer.py remain for now.
How was this tested?
running a few gens with yamls I had around and unittests.
If this makes graphical changes, please attach screenshots.