MultiServer: Prevent invalid *_mode option values.
#3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
is: bug/fix
github-actions
bot
added
the
waiting-on: peer-review
ThePhar
removed
the
waiting-on: peer-review
Berserker66
approved these changes
Apr 18, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Bug Report Thread: https://discord.com/channels/731205301247803413/1227391160520278066
Server admins are allowed to send any value when using the
/optioncommand forrelease_mode,collect_mode, andremaining_modewhich acts likegoalwhen a user runs!releaseor other variant because of the final else-clause in the command processing methods, if it is not one of the valid options:enabled,disabled,auto,goal,auto_enabled.These changes add an additional check for explicitly the
*_modeoptions to ensure they are given a valid value or it will fail with a "Unrecognized {*_mode} value" log printed to the standard output.How was this tested?
Comparing functionality between before and after this patch with
/option release_mode off(an invalid value), and confirmed that post-patch the server did not accept the value and printed the list of valid options instead.If this makes graphical changes, please attach screenshots.
Before:
After:
