Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hylics 2: Fix logic for medallions in vault #3148

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Hylics 2: Fix logic for medallions in vault #3148

merged 1 commit into from
Apr 16, 2024

Conversation

TRPG0
Copy link
Collaborator

@TRPG0 TRPG0 commented Apr 14, 2024

Even in current year people are still finding small mistakes in my logic for this game 😔

@TRPG0 TRPG0 added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 14, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 14, 2024
@ScipioWright ScipioWright added the affects: release/blocker Issues/PRs that must be addressed before next official release. label Apr 15, 2024
ScipioWright
ScipioWright approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk Hylics 2 at all, just the logic looks like it's written correctly, and I trust that if it's a logic bug fix that the world maintainer knows what they're doing regarding the actual logic.

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 15, 2024
@Berserker66 Berserker66 merged commit a1ef254 into ArchipelagoMW:main Apr 16, 2024
15 checks passed
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@TRPG0 @qwint
Hylics 2: Fix logic for medallions in vault (ArchipelagoMW#3148)
edd3bbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

Assignees
No one assigned
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TRPG0 @Berserker66 @ScipioWright