[Yoshi's Island] Minor Fixes #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Exempt-Medic
approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Changes LGTM. Merged into main and it generates. Only other instance of "guranteed" is in CV64 which is outside the scope of this
Exempt-Medic
added
is: bug/fix
|
Personal comment, 10-Ups were always supposed to be classed as useful, it seems when I was refactoring the classification assignment, they accidentally got marked as filler and slipped past my notice. |
ScipioWright
suggested changes
Apr 14, 2024
ScipioWright
added
waiting-on: author
ScipioWright
approved these changes
Apr 14, 2024
Exempt-Medic
added
waiting-on: core-review
Berserker66
approved these changes
Apr 18, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
-Changed '10-Up' classification to Useful
-Fixed option typo from 'bosses_guranteed' to 'bosses_guaranteed'
How was this tested?
I generated after changing them to make sure they worked.
If this makes graphical changes, please attach screenshots.