Core: add visibility attribute to Option

[Berserker66]

What is this fixing or adding?

allows hiding of options in certain contexts. Multiple use cases have been discussed, this brings legacy alerts for LttP as one such use case with it.

How was this tested?

I've tested each flag barely, so this could use some more testing.

[Ziktofel]

wouldn't be "not_simple_ui" a common value?

[KScl]

(Visibility.all - Visibility.spoiler) may also be a common enough use case to be specified here, for options that only have visual effects on the game and have no effect on generation. (Flashing reduction, sprite choice, etc.)

It would certainly be nice to clean up the spoiler log a little bit.

[Ziktofel]

SC2 player colors are visual-only too

[MatthewMarinets]

I'd say it's easy enough to get "all except X" with Visibility.all ^ Visibility.spoiler, to use spoiler for an example. I'd be fine to leave this as-is.

[Ziktofel]

Is this following test fragile?

=========================== short test summary info ============================
[Game] (game="Kirby's Dream Land 3") SUBFAIL worlds/kdl3/test/test_shuffles.py::TestAnimalShuffle::test_all_state_can_reach_everything - execnet.gateway_base.DumpError: can't serialize <class 'worlds.kdl3.Locations.KDL3Location'>
FAILED worlds/kdl3/test/test_shuffles.py::TestAnimalShuffle::test_all_state_can_reach_everything - AssertionError: <BaseClasses.MultiWorld object at 0x7f75f6191ad0> is not false : World Kirby's Dream Land 3 leaked MultiWorld object

[Silvris]

Is this following test fragile?

=========================== short test summary info ============================
[Game] (game="Kirby's Dream Land 3") SUBFAIL worlds/kdl3/test/test_shuffles.py::TestAnimalShuffle::test_all_state_can_reach_everything - execnet.gateway_base.DumpError: can't serialize <class 'worlds.kdl3.Locations.KDL3Location'>
FAILED worlds/kdl3/test/test_shuffles.py::TestAnimalShuffle::test_all_state_can_reach_everything - AssertionError: <BaseClasses.MultiWorld object at 0x7f75f6191ad0> is not false : World Kirby's Dream Land 3 leaked MultiWorld object

The failure is known (seems to be a shortcoming of fill_restrictive, hoping to have a PR for it soon). Hadn't seen the leaking before though, which is a little worrying. Wonder if that's a result of the weird failure state (since only Github hits the DumpError).