Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noita: Add Meat Realm #3119

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Noita: Add Meat Realm #3119

merged 5 commits into from
Apr 18, 2024

Conversation

ScipioWright
Copy link
Collaborator

What is this fixing or adding?

At long last, the Noita beta is no longer a beta, and is now live. And so, meat biome.
The client was already modified a long while back to accept the new locations (literally a 1 line change).

How was this tested?

Gen, running the general unit tests.

If this makes graphical changes, please attach screenshots.

256413040-897808c0-86b3-4fca-b590-398b4ba40d6a

@ScipioWright ScipioWright requested a review from heinermann April 8, 2024 18:07
@ScipioWright ScipioWright added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 8, 2024
@ScipioWright ScipioWright changed the title Noita: Add Meat Biome Noita: Add Meat Realm Apr 8, 2024
heinermann
heinermann approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@heinermann heinermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, you might want to remove the commented out collapsed mines which originally used those IDs though.

nbrochu
nbrochu approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@nbrochu nbrochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple code changes. Made the branch an APWorld and it generates just fine. LGTM

image

@nbrochu nbrochu added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 17, 2024
@Berserker66 Berserker66 merged commit 5ec342a into ArchipelagoMW:main Apr 18, 2024
15 of 16 checks passed
@ScipioWright ScipioWright deleted the noita-meat2 branch May 3, 2024 13:38
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@ScipioWright @qwint
Noita: Add Meat Realm (ArchipelagoMW#3119)
8470a96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

@heinermann heinermann heinermann approved these changes

@nbrochu nbrochu nbrochu approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScipioWright @nbrochu @heinermann @Berserker66