Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC2: Fix Typos in location names #3108

Merged
merged 1 commit into from
Apr 12, 2024
Merged

SC2: Fix Typos in location names #3108

merged 1 commit into from
Apr 12, 2024

Conversation

Ziktofel
Copy link
Collaborator

@Ziktofel Ziktofel commented Apr 6, 2024

What is this fixing or adding?

Fix Typos in location names in Templar's Charge

How was this tested?

String fix, verified that this string isn't used elsewhere

If this makes graphical changes, please attach screenshots.

No

@Ziktofel Ziktofel added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 6, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 6, 2024
Exempt-Medic
Exempt-Medic approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward fix, no other instances elsewhere in the world

nicholassaylor
nicholassaylor approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 7, 2024
MatthewMarinets
MatthewMarinets approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@MatthewMarinets MatthewMarinets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 100% of the changes and am very confident the changes are correct.

@Berserker66 Berserker66 merged commit 30dda01 into ArchipelagoMW:main Apr 12, 2024
15 checks passed
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Ziktofel @EmilyV99
SC2: Fix Typos in location names (ArchipelagoMW#3108)
ea48446
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Ziktofel @EmilyV99
SC2: Fix Typos in location names (ArchipelagoMW#3108)
cfce339
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Ziktofel @qwint
SC2: Fix Typos in location names (ArchipelagoMW#3108)
c2f00ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@MatthewMarinets MatthewMarinets MatthewMarinets approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ziktofel @Berserker66 @MatthewMarinets @Exempt-Medic @nicholassaylor