Pokémon Red and Blue: 0.4.5 Fixes

[Alchav]

What is this fixing or adding?

• After making a fix to the route 4 subregions in the last update, the item location wound up in the wrong one. This fixes that.
• Fixes a bug in the loop for 10 attempts to get Door Shuffle done, which caused a crash on the third attempt due to the second run corrupting the cache since it wasn't copied.
• Fixes a bug in the client. I confused the Route 18 Gate script value with the Route 18 script value. Assumption of max valid value was based on Route 18, leading to the client reporting a crash when being stopped by the route 18 guard when you have no bicycle.
• Fixes an issue with verification of available HM moves. In order to preserve expectations you'd have with various combinations of settings, this verification is now in a function verify_hm_moves which is called both during pre_fill, and after badge placement in fill_hook. fill_hook gets two attempts to place badges without verifying hm moves, after which it starts collecting all pokemon into the state. This will happen if the Pokémons' locations and learnsets are not allowing badges to place, and hm move verification will fix it afterwards. TL;DR this should fix badges failing to place when badgesanity is off + door shuffle is off or on simple.

How was this tested?

The Door Shuffle loop fix and hm verification fix were tested with yamls and seeds that were failing on main. The other fixes have not been tested yet but should be right.