Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC2: Fix vanilla mission order connection #3101

Merged

Conversation

Ziktofel
Copy link
Collaborator

@Ziktofel Ziktofel commented Apr 5, 2024

What is this fixing or adding?

Fixes vanilla mission order connection in NCO (a copy-paste error)

How was this tested?

Generated an offending YAML, that failed before

If this makes graphical changes, please attach screenshots.

No

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 5, 2024
@Ziktofel Ziktofel added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 5, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightfoward change that generates just fine. Checked for other instances of the same error and found the second one that is now fixed.

@Ziktofel Ziktofel added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 6, 2024
@Berserker66 Berserker66 merged commit b97cee4 into ArchipelagoMW:main Apr 11, 2024
15 checks passed
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants