SMZ3: Use correct font tiles for cross-world items in SM #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
|
Pinging codeowner @lordlou because I forgot to do so when initially opening this PR. |
lordlou
approved these changes
Apr 12, 2024
ScipioWright
approved these changes
Apr 19, 2024
ScipioWright
added
waiting-on: core-review
Berserker66
approved these changes
Apr 21, 2024
ThePhar
approved these changes
Apr 21, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The code for showing cross-world items in the SM half of SMZ3 appears to have been copied from the AP implementation of the SM randomizer; however, SMZ3 uses a different font for the popups in SM. This updates the text map accordingly, allowing numbers, lowercase letters, and a few other special characters to display correctly. It also replaces underscores with hyphens to avoid showing holes in the popup.
How was this tested?
Generating seeds with problematic items plandoed onto Morphing Ball.
If this makes graphical changes, please attach screenshots.
Left is original, right is with this PR.
