Skip to content

TUNIC: ER Refactor for better plando connections, fewer shops improvement #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
May 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
a6e1765
Fixed shop changes
ScipioWright Mar 31, 2024
75887f2
Merge branch 'ArchipelagoMW:main' into tunc-fewer-shops-change
ScipioWright Apr 1, 2024
32c99cd
Update option description
ScipioWright Apr 1, 2024
c32328e
Apply suggestions from Vi's review (thank you)
ScipioWright Apr 3, 2024
ef8c93d
Fix for plando connections on a full scene
ScipioWright Apr 11, 2024
655f9b3
Plando connections should work better now for complicated paths
ScipioWright Apr 12, 2024
0727ff6
Merge branch 'ArchipelagoMW:main' into tunc-fewer-shops-change
ScipioWright Apr 12, 2024
ecbd143
Even more good plando connections yes
ScipioWright Apr 12, 2024
ff40c6c
Starting to move the info over
ScipioWright Apr 12, 2024
1d56af7
Fixing up formatting a bit
ScipioWright Apr 12, 2024
0dd557a
Remove unneeded item info
ScipioWright Apr 12, 2024
ed14cab
Put in updated_reachable_regions, to replace add_dependent_regions
ScipioWright Apr 12, 2024
f8c3dea
Updated to match ladder shuffle
ScipioWright Apr 13, 2024
872d234
More stuff I guess
ScipioWright Apr 13, 2024
0b659e5
It functions!
ScipioWright Apr 13, 2024
4c0468a
It mostly works with plando now, some slight issues still
ScipioWright Apr 13, 2024
c2b2bae
Fixed minor logic bug
ScipioWright Apr 13, 2024
024c0b1
Fixed world leakage
ScipioWright Apr 13, 2024
06548cd
Change exception message
ScipioWright Apr 13, 2024
174260b
Make exception message better for troubleshooting failed connections
ScipioWright Apr 13, 2024
b5c68a4
Merge branch 'main' into tunc-fewer-shops-change
ScipioWright Apr 14, 2024
2fe100f
Merge branch 'main' into tunc-fewer-shops-change
ScipioWright Apr 14, 2024
ad144b1
Merge branch 'main' into tunc-fewer-shops-change
ScipioWright Apr 21, 2024
02aabb5
Merge branch 'main' into tunc-fewer-shops-change
ScipioWright May 2, 2024
236f67f
Merge remote-tracking branch 'origin/main' into tunc-fewer-shops-change
ScipioWright May 3, 2024
344f879
Merged with main
ScipioWright May 3, 2024
24b31d1
technically a logic fix but it would never matter cause no start shuffle
ScipioWright May 4, 2024
0a38b80
Add a couple more alias item groups cause yeah
ScipioWright May 4, 2024
ff0611a
Rename beneath the vault front -> beneath the vault main
ScipioWright May 4, 2024
be2f136
Flip lantern access rule to the region
ScipioWright May 4, 2024
ef5d47b
Add missing connection to traversal reqs
ScipioWright May 4, 2024
2e5e40c
Move start_inventory_from_pool to the top so that it's next to start_…
ScipioWright May 10, 2024
6e87a18
Reword the fixed shop description slightly
ScipioWright May 10, 2024
65f7d9e
Refactor per ixrec's comments
ScipioWright May 14, 2024
b691bae
Merge branch 'main' into tunc-fewer-shops-change
ScipioWright May 15, 2024
ce9eadb
Greatly reduced an overcomplicated block because Vi is cool and smart…
ScipioWright May 18, 2024
d0d13ab
Rewrite traversal reqs thing per Vi's comments
ScipioWright May 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,171 changes: 815 additions & 356 deletions worlds/tunic/er_data.py

Large diffs are not rendered by default.

23 changes: 13 additions & 10 deletions worlds/tunic/er_rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@ def set_er_region_rules(world: "TunicWorld", ability_unlocks: Dict[str, int], re
connecting_region=regions["Overworld Well Ladder"],
rule=lambda state: has_ladder("Ladders in Well", state, player, options))
regions["Overworld Well Ladder"].connect(
connecting_region=regions["Overworld"])
connecting_region=regions["Overworld"],
rule=lambda state: has_ladder("Ladders in Well", state, player, options))

# nmg: can ice grapple through the door
regions["Overworld"].connect(
Expand Down Expand Up @@ -706,17 +707,18 @@ def set_er_region_rules(world: "TunicWorld", ability_unlocks: Dict[str, int], re
connecting_region=regions["Fortress Exterior from Overworld"])

regions["Beneath the Vault Ladder Exit"].connect(
connecting_region=regions["Beneath the Vault Front"],
rule=lambda state: has_ladder("Ladder to Beneath the Vault", state, player, options))
regions["Beneath the Vault Front"].connect(
connecting_region=regions["Beneath the Vault Main"],
rule=lambda state: has_ladder("Ladder to Beneath the Vault", state, player, options)
and has_lantern(state, player, options))
regions["Beneath the Vault Main"].connect(
connecting_region=regions["Beneath the Vault Ladder Exit"],
rule=lambda state: has_ladder("Ladder to Beneath the Vault", state, player, options))

regions["Beneath the Vault Front"].connect(
connecting_region=regions["Beneath the Vault Back"],
rule=lambda state: has_lantern(state, player, options))
regions["Beneath the Vault Main"].connect(
connecting_region=regions["Beneath the Vault Back"])
regions["Beneath the Vault Back"].connect(
connecting_region=regions["Beneath the Vault Front"])
connecting_region=regions["Beneath the Vault Main"],
rule=lambda state: has_lantern(state, player, options))

regions["Fortress East Shortcut Upper"].connect(
connecting_region=regions["Fortress East Shortcut Lower"])
Expand Down Expand Up @@ -870,6 +872,9 @@ def set_er_region_rules(world: "TunicWorld", ability_unlocks: Dict[str, int], re
regions["Rooted Ziggurat Portal Room Entrance"].connect(
connecting_region=regions["Rooted Ziggurat Lower Back"])

regions["Zig Skip Exit"].connect(
connecting_region=regions["Rooted Ziggurat Lower Front"])

regions["Rooted Ziggurat Portal"].connect(
connecting_region=regions["Rooted Ziggurat Portal Room Exit"],
rule=lambda state: state.has("Activate Ziggurat Fuse", player))
Expand Down Expand Up @@ -1453,8 +1458,6 @@ def set_er_location_rules(world: "TunicWorld", ability_unlocks: Dict[str, int])
# Beneath the Vault
set_rule(multiworld.get_location("Beneath the Fortress - Bridge", player),
lambda state: state.has_group("Melee Weapons", player, 1) or state.has_any({laurels, fire_wand}, player))
set_rule(multiworld.get_location("Beneath the Fortress - Obscured Behind Waterfall", player),
lambda state: has_lantern(state, player, options))

# Quarry
set_rule(multiworld.get_location("Quarry - [Central] Above Ladder Dash Chest", player),
Expand Down
Loading
Loading