Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: remove now unused stuff in Generate.py #3035

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Core: remove now unused stuff in Generate.py #3035

merged 1 commit into from
Apr 8, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

removes now unused stuff in Generate.py

How was this tested?

Not yet, I'm in Generate for another PR and ran into this. Will test it together with the change I actually wanted to do.

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 26, 2024
@ScipioWright ScipioWright added the is: refactor/cleanup Improvements to code/output readability or organizization. label Mar 26, 2024
@alwaysintreble alwaysintreble added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 29, 2024
@Berserker66 Berserker66 merged commit 1021df8 into main Apr 8, 2024
24 checks passed
@Berserker66 Berserker66 deleted the core_sleeker_generate branch April 8, 2024 22:24
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Berserker66 @EmilyV99
Core: remove now unused stuff in Generate.py (ArchipelagoMW#3035)
f3fa809
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Berserker66 @EmilyV99
Core: remove now unused stuff in Generate.py (ArchipelagoMW#3035)
c76314b
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Berserker66 @qwint
Core: remove now unused stuff in Generate.py (ArchipelagoMW#3035)
c2502d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThePhar ThePhar ThePhar approved these changes

@beauxq beauxq beauxq approved these changes

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Berserker66 @silasary @beauxq @ThePhar @alwaysintreble @ScipioWright