Skip to content

TUNIC: Location groups for each area of the game #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1dbfe61
huzzah, location groups
ScipioWright Mar 24, 2024
f86cae2
scope creep pog
ScipioWright Mar 24, 2024
49d3220
Apply suggestion to the other spot it is applicable at too
ScipioWright Mar 24, 2024
7a2580c
apply berserker's suggestion
ScipioWright Mar 24, 2024
111aa1d
Remove extra location group for shops
ScipioWright Mar 24, 2024
b373d4b
Merge branch 'main' into tunc-location-groups
ScipioWright Mar 28, 2024
bbb32e5
Merge branch 'main' into tunc-location-groups
ScipioWright Apr 2, 2024
416eff7
Fire rod for magic wand
ScipioWright Apr 12, 2024
d2293f0
Capitalize itme name groups
ScipioWright Apr 12, 2024
6e2e623
Update docs to capitalize item name groups, remove the little section…
ScipioWright Apr 12, 2024
3767e54
Merge branch 'main' into tunc-location-groups
ScipioWright Apr 12, 2024
2343d7c
Fix rule with item group name
ScipioWright Apr 12, 2024
0ac1bdc
Capitalization is cool
ScipioWright Apr 13, 2024
7692d5d
Merge branch 'main' into tunc-location-groups
ScipioWright Apr 14, 2024
5104eba
Fix merge mistake
ScipioWright Apr 14, 2024
61ba415
Merge branch 'main' into tunc-location-groups
ScipioWright Apr 14, 2024
9a2d587
Merge branch 'main' into tunc-location-groups
ScipioWright Apr 19, 2024
d86f5e1
Add Flask group, remove Potions group
ScipioWright Apr 20, 2024
3ef7c95
Update docs to detail how to find item and location groups
ScipioWright Apr 20, 2024
693bd28
Merge branch 'main' into tunc-location-groups
ScipioWright Apr 21, 2024
762a041
Revise per Vi's comment
ScipioWright Apr 21, 2024
51ef115
Fix test
ScipioWright Apr 21, 2024
5cde3c8
fuzzy matching please stop
ScipioWright Apr 28, 2024
df438a3
Remove test change that was meant for a different branch
ScipioWright Apr 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion worlds/tunic/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def extend_hint_information(self, hint_data: Dict[int, Dict[int, str]]):
name, connection = connection
# for LS entrances, we just want to give the portal name
if "(LS)" in name:
name, _ = name.split(" (LS) ")
name = name.split(" (LS) ", 1)[0]
# was getting some cases like Library Grave -> Library Grave -> other place
if name in portal_names and name != previous_name:
previous_name = name
Expand Down
5 changes: 3 additions & 2 deletions worlds/tunic/docs/en_TUNIC.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,11 @@ For the Entrance Randomizer:
- The elevator in Cathedral is immediately usable without activating the fuse. Activating the fuse does nothing.

## What item groups are there?
Bombs, consumables (non-bomb ones), weapons, melee weapons (stick and sword), keys, hexagons, offerings, hero relics, cards, golden treasures, money, pages, and abilities (the three ability pages). There are also a few groups being used for singular items: laurels, orb, dagger, magic rod, holy cross, prayer, icebolt, and progressive sword.
Bombs, consumables (non-bomb ones), weapons, melee weapons (stick and sword), keys, hexagons, offerings, hero relics, cards, golden treasures, money, pages, abilities (the three ability pages), and ladders (for shuffle ladders). There are also a few groups being used for singular items: laurels, orb, dagger, magic rod, holy cross, prayer, icebolt, and progressive sword.

## What location groups are there?
Holy cross (for all holy cross checks), fairies (for the two fairy checks), well (for the coin well checks), shop, bosses (for the bosses with checks associated with them), hero relic (for the 6 hero grave checks), and ladders (for the ladder items when you have shuffle ladders enabled).
Holy Cross (for all Holy Cross checks), Fairies (for the two fairy checks), Well (for the coin well checks), Shop, and Bosses (for the bosses with checks associated with them).
Additionally, there are location groups for each area of the game which share their name with the beginning of the location names (the part before the -).

## Is Connection Plando supported?
Yes. The host needs to enable it in their `host.yaml`, and the player's yaml needs to contain a plando_connections block.
Expand Down
1 change: 1 addition & 0 deletions worlds/tunic/items.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ def get_item_group(item_name: str) -> str:
"orb": {"Magic Orb"},
"dagger": {"Magic Dagger"},
"magic rod": {"Magic Wand"},
"wand": {"Magic Wand"},
"holy cross": {"Pages 42-43 (Holy Cross)"},
"prayer": {"Pages 24-25 (Prayer)"},
"icebolt": {"Pages 52-53 (Icebolt)"},
Expand Down
Loading
Loading