-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvui: use all flags in Item Class tooltip #3011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Does not hurt to support that, tho I'm not exactly sure what could be a usecase for an item being both progression and useful, for instance. 🤔
Is it just a UI thing, or does something in the fill, for instance, behave differently?
Mostly a visual thing, but there was discussion about using the combination of progression + useful to note progression that is significantly better than other progression in the world (ie LttP Moon Pearl vs Shovel, or Stardew Shipping Bin vs a Friendsanity heart). No matter the route taken eventually, this is likely a change that would need done anyways. For fill, I believe the progression flag would take priority. |
That make total sense. Especially in Stardew, we have so many progression items that just unlock one or two checks without being significant progress. Giving more hint to the fill algorithm on what is really important and what is not seems useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It functions just fine and the code looks good
What is this fixing or adding?
Allows the kivy UI to multi-class the items tooltip
How was this tested?
If this makes graphical changes, please attach screenshots.