Launcher: make launcher scrollable #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Berserker66
approved these changes
Mar 3, 2024
github-actions
bot
removed
the
waiting-on: peer-review
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
As Archipelago grows and more clients are added, the amount of space given to any given client in the launcher grows ever smaller. This changes the launcher such that the list of tools and clients can be scrolled, and each button is rendered at a straight height of 40.
How was this tested?
Opening the launcher, confirming the visual changes. Clicked on the OoT Adjuster, Minecraft Client, and Undertale Clients and confirmed the correct program was launched.
If this makes graphical changes, please attach screenshots.
(I don't have recording software on this machine, so hopefully screenshot will suffice)
