Skip to content

BizHawkClient: Add error message if patching fails #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2024
Merged

BizHawkClient: Add error message if patching fails #2877

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816f9e3
BizHawkClient: Add error message if patching fails
Zunawe Feb 29, 2024
229c912
BizHawkClient: Generalize exception logging during patching
Zunawe Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions worlds/_bizhawk/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,12 @@ async def _run_game(rom: str):


async def _patch_and_run_game(patch_file: str):
metadata, output_file = Patch.create_rom_file(patch_file)
Utils.async_start(_run_game(output_file))
try:
metadata, output_file = Patch.create_rom_file(patch_file)
Utils.async_start(_run_game(output_file))
except (FileNotFoundError, ValueError) as exc:
logger.info("ERROR: Unable to patch game. It's likely that your ROM is missing or is an incompatible version.")
raise exc


def launch() -> None:
Expand Down