Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF1: Update Location Names #2838

Merged
merged 1 commit into from
Mar 3, 2024
Merged

FF1: Update Location Names #2838

merged 1 commit into from
Mar 3, 2024

Conversation

wildham0
Copy link
Contributor

@wildham0 wildham0 commented Feb 17, 2024 •
edited
Loading

What is this fixing or adding?

Update location names to be more descriptive from community's input, making it easier figure out what locations hints are referring to.

How was this tested?

Generated several seeds without issue and checked every possible locations, double checking with the client.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 17, 2024
@ScipioWright ScipioWright added is: refactor/cleanup Improvements to code/output readability or organizization. is: enhancement Issues requesting new features or pull requests implementing new features. and removed is: refactor/cleanup Improvements to code/output readability or organizization. labels Feb 18, 2024
agilbert1412
agilbert1412 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more wordy, which I imagine is a positive here

Alchav
Alchav approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Alchav Alchav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good location names are good

@alwaysintreble alwaysintreble added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 3, 2024
@Berserker66 Berserker66 merged commit b8bf67a into ArchipelagoMW:main Mar 3, 2024
10 checks passed
@github-actions github-actions bot removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Mar 3, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@wildham0 @EmilyV99
FF1: Update Location Names (ArchipelagoMW#2838)
30fa84c
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@wildham0 @EmilyV99
FF1: Update Location Names (ArchipelagoMW#2838)
af0c000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benny-dreamly benny-dreamly benny-dreamly approved these changes

@Alchav Alchav Alchav approved these changes

@agilbert1412 agilbert1412 agilbert1412 approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wildham0 @silasary @Berserker66 @agilbert1412 @Alchav @benny-dreamly @alwaysintreble @ScipioWright